[
https://issues.apache.org/jira/browse/HDDS-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955097#comment-16955097
]
Marton Elek commented on HDDS-2323:
-----------------------------------
Can you please upload your patch as a pull request next time? It can be more
safe (for example this patch introduced a new findbug error which breaks
master)
{code:java}
M P UrF: Unread field:
org.apache.hadoop.ozone.audit.AuditMessage$Builder.params At
AuditMessage.java:[line 106] {code}
> Mem allocation: Optimise AuditMessage::build()
> ----------------------------------------------
>
> Key: HDDS-2323
> URL: https://issues.apache.org/jira/browse/HDDS-2323
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Rajesh Balamohan
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: performance
> Fix For: 0.5.0
>
> Attachments: HDDS-2323.01.patch, Screenshot 2019-10-18 at 8.24.52
> AM.png
>
>
> String format allocates/processes more than
> {color:#000000}OzoneAclUtil.fromProtobuf in write benchmark.{color}
> {color:#000000}Would be good to use + instead of format.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
