[
https://issues.apache.org/jira/browse/HDDS-2335?focusedWorklogId=331040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331040
]
ASF GitHub Bot logged work on HDDS-2335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/19 09:05
Start Date: 20/Oct/19 09:05
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #62: HDDS-2335.
Params not included in AuditMessage
URL: https://github.com/apache/hadoop-ozone/pull/62
## What changes were proposed in this pull request?
Include operation parameters in audit messages like before
[HDDS-2323](https://github.com/apache/hadoop-ozone/commit/b9618834c9902fc8fd9ae12872092cfb1e5c1be3).
https://issues.apache.org/jira/browse/HDDS-2335
## How was this patch tested?
Added unit test.
Verified Findbugs violation is fixed.
Tested using Freon:
```
2019-10-20 08:54:19,437 | INFO | OMAudit | user=hadoop | ip=192.168.144.3 |
op=CREATE_VOLUME {admin=hadoop, owner=hadoop, volume=vol-0-52867,
creationTime=1571561659397, quotaInBytes=1152921504606846976, objectID=1,
updateID=1} | ret=SUCCESS |
2019-10-20 08:54:19,497 | INFO | OMAudit | user=hadoop | ip=192.168.144.3 |
op=CREATE_BUCKET {volume=vol-0-52867, bucket=bucket-0-43473, gdprEnabled=null,
acls=[user:hadoop:a[ACCESS], group:users:a[ACCESS]], isVersionEnabled=false,
storageType=DISK, creationTime=1571561659483} | ret=SUCCESS |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 331040)
Remaining Estimate: 0h
Time Spent: 10m
> Params not included in AuditMessage
> -----------------------------------
>
> Key: HDDS-2335
> URL: https://issues.apache.org/jira/browse/HDDS-2335
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HDDS-2323 introduced the following Findbugs violation:
> {noformat:title=https://github.com/elek/ozone-ci-q4/blob/master/trunk/trunk-nightly-20191020-r5wzl/findbugs/summary.txt}
> M P UrF: Unread field:
> org.apache.hadoop.ozone.audit.AuditMessage$Builder.params At
> AuditMessage.java:[line 106]
> {noformat}
> Which reveals that {{params}} is now not logged in audit messages:
> {noformat}
> 2019-10-20 08:41:35,248 | INFO | OMAudit | user=hadoop | ip=192.168.128.2 |
> op=CREATE_VOLUME | ret=SUCCESS |
> 2019-10-20 08:41:35,312 | INFO | OMAudit | user=hadoop | ip=192.168.128.2 |
> op=CREATE_BUCKET | ret=SUCCESS |
> 2019-10-20 08:41:35,407 | INFO | OMAudit | user=hadoop | ip=192.168.128.2 |
> op=ALLOCATE_KEY | ret=SUCCESS |
> 2019-10-20 08:41:37,355 | INFO | OMAudit | user=hadoop | ip=192.168.128.2 |
> op=COMMIT_KEY | ret=SUCCESS |
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
