[
https://issues.apache.org/jira/browse/HDFS-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins updated HDFS-2454:
------------------------------
Description: We can hoist the maxXceiverCount out of
DataXceiverServer#run, there's no need to check each time we accept a
connection, we can accept when we create a thread. (was: // Make sure
the xceiver count is not exceeded
int curXceiverCount = datanode.getXceiverCount();
if (curXceiverCount > dataXceiverServer.maxXceiverCount) {
throw new IOException("xceiverCount " + curXceiverCount
+ " exceeds the limit of concurrent xcievers "
+ dataXceiverServer.maxXceiverCount);
})
Affects Version/s: 0.23.0
Fix Version/s: 0.23.1
Issue Type: Improvement (was: Bug)
Hadoop Flags: Reviewed
+1 looks good. Given that we're checking the # threads agree we don't need to
re-check that on each accept (this could cause multiple xceivers to exit).
> Move maxXceiverCount check to before starting the thread in dataXceiver
> -----------------------------------------------------------------------
>
> Key: HDFS-2454
> URL: https://issues.apache.org/jira/browse/HDFS-2454
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Uma Maheswara Rao G
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.23.1
>
> Attachments: HDFS-2454.patch
>
>
> We can hoist the maxXceiverCount out of DataXceiverServer#run, there's no
> need to check each time we accept a connection, we can accept when we create
> a thread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
