[
https://issues.apache.org/jira/browse/HDFS-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956276#comment-16956276
]
Wei-Chiu Chuang commented on HDFS-14884:
----------------------------------------
LGTM
Nit:
{code}
import static org.apache.hadoop.hdfs.server.common.HdfsServerConstants.*;
{code}
please refrain from using wildcard import.
Test: should we add a fail() at the end of try block to make sure it does throw
an exception when setting xattr on zone2File? Also, it would be better if you
can add to the error log that the error is expected. Or use assertThrows().
> Add sanity check that zone key equals feinfo key while setting Xattrs
> ---------------------------------------------------------------------
>
> Key: HDFS-14884
> URL: https://issues.apache.org/jira/browse/HDFS-14884
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption, hdfs
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Attachments: HDFS-14884.001.patch, HDFS-14884.002.patch,
> hdfs_distcp.patch
>
>
> Currently, it is possible to set an external attribute where the zone key is
> not the same as feinfo key. This jira will add a precondition before setting
> this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
