[
https://issues.apache.org/jira/browse/HDFS-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956366#comment-16956366
]
Fengnan Li commented on HDFS-14914:
-----------------------------------
[~ayushtkn] Thanks for the feedback!
I rephrased the description so that Router <> Observer is removed, and there is
no problem in the current code for sure.
There is no right or wrong here. Generally I don't view this patch as a bug
fix, and it is more like a small improvement since in this case,
StandbyException gives more clear direction than RetriableException and
retrying on a long running safemode doesn't help. The exception handling (not
distinguishing these two) in ObserverReadProxyProvider makes it work but it is
sub optimal compared to a clear distinguishing.
> Observer should throw StandbyException in Safemode
> --------------------------------------------------
>
> Key: HDFS-14914
> URL: https://issues.apache.org/jira/browse/HDFS-14914
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Minor
> Attachments: HDFS-14914-001.patch
>
>
> When observer is in safemode, calling getBlockLocations will make it throw
> RetriableException as in HDFS-13898. However, during startup the safemode is
> taking a really long time and retry would not help much here.
> The change is to make it failover so that Router can immediately try another
> Observer or Active namenode (depends on the design). The current
> ObserverReadProxyProvider doesn't get affected since both RetriableException
> and StandbyException will make it failover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
