[
https://issues.apache.org/jira/browse/HDDS-2344?focusedWorklogId=331803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331803
]
ASF GitHub Bot logged work on HDDS-2344:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/19 05:45
Start Date: 22/Oct/19 05:45
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #71:
HDDS-2344. Add immutable entries in to the DoubleBuffer for Volume requests.
URL: https://github.com/apache/hadoop-ozone/pull/71
…quests.
## What changes were proposed in this pull request?
OMVolumeCreateRequest.java L159:
omClientResponse =
new OMVolumeCreateResponse(omVolumeArgs,volumeList, omResponse.build());
We add this to double-buffer, and double-buffer flushThread which is running
in the background when picks up, converts to protoBuf and to ByteArray and
write to rocksDB tables. So, during this conversion(This conversion will be
done without any lock acquire), if any other request changes internal
structure(like acls list) of OmVolumeArgs we might get
ConcurrentModificationException.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2344
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Ran TestOzoneRpcClient which tests this code path and also added a new test
for clone method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 331803)
Remaining Estimate: 0h
Time Spent: 10m
> Add immutable entries in to the DoubleBuffer for Volume requests.
> -----------------------------------------------------------------
>
> Key: HDDS-2344
> URL: https://issues.apache.org/jira/browse/HDDS-2344
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> OMVolumeCreateRequest.java L159:
> {code:java}
> omClientResponse =
> new OMVolumeCreateResponse(omVolumeArgs,volumeList,
> omResponse.build());{code}
>
> We add this to double-buffer, and double-buffer flushThread which is running
> in the background when picks up, converts to protoBuf and to ByteArray and
> write to rocksDB tables. So, during this conversion(This conversion will be
> done without any lock acquire), if any other request changes internal
> structure(like acls list) of OmVolumeArgs we might get
> ConcurrentModificationException.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
