[ 
https://issues.apache.org/jira/browse/HDDS-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai updated HDDS-2346:
-----------------------------------
    Status: Patch Available  (was: In Progress)

> Replication manager config has wrong description
> ------------------------------------------------
>
>                 Key: HDDS-2346
>                 URL: https://issues.apache.org/jira/browse/HDDS-2346
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Replication manager's configuration for its own interval:
> {code:title=https://github.com/apache/hadoop-ozone/blob/eb1d77e3206fab1a4ac0573507c9deb2b56b9ea1/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java#L808-L822}
>     @Config(key = "thread.interval",
>         type = ConfigType.TIME,
>         defaultValue = "300s",
>         tags = {SCM, OZONE},
>         description = "When a heartbeat from the data node arrives on SCM, "
>             + "It is queued for processing with the time stamp of when the "
>             + "heartbeat arrived. There is a heartbeat processing thread "
>             + "inside "
>             + "SCM that runs at a specified interval. This value controls how 
> "
>             + "frequently this thread is run.\n\n"
>             + "There are some assumptions build into SCM such as this "
>             + "value should allow the heartbeat processing thread to run at "
>             + "least three times more frequently than heartbeats and at least 
> "
>             + "five times more than stale node detection time. "
>             + "If you specify a wrong value, SCM will gracefully refuse to "
>             + "run. "
>             + "For more info look at the node manager tests in SCM.\n"
>             + "\n"
>             + "In short, you don't need to change this."
>     )
> {code}
> duplicates SCM heartbeat interval doc:
> {code:title=https://github.com/apache/hadoop-ozone/blob/eb1d77e3206fab1a4ac0573507c9deb2b56b9ea1/hadoop-hdds/common/src/main/resources/ozone-default.xml#L973-L991}
>   <property>
>     <name>ozone.scm.heartbeat.thread.interval</name>
>     <value>3s</value>
>     <tag>OZONE, MANAGEMENT</tag>
>     <description>
>       When a heartbeat from the data node arrives on SCM, It is queued for
>       processing with the time stamp of when the heartbeat arrived. There is a
>       heartbeat processing thread inside SCM that runs at a specified 
> interval.
>       This value controls how frequently this thread is run.
>       There are some assumptions build into SCM such as this value should 
> allow
>       the heartbeat processing thread to run at least three times more
>       frequently than heartbeats and at least five times more than stale node
>       detection time. If you specify a wrong value, SCM will gracefully refuse
>       to run. For more info look at the node manager tests in SCM.
>       In short, you don't need to change this.
>     </description>
>   </property>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to