[
https://issues.apache.org/jira/browse/HDFS-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960979#comment-16960979
]
Lisheng Sun commented on HDFS-14936:
------------------------------------
[~ayushtkn]
all of subclasses of InnerNode as follow:
InnerNodeImpl extends InnerNode
DFSTopologyNodeImpl extends InnerNodeImpl
InnerNodeWithNodeGroup extends InnerNodeImpl
all these class have getNumOfChildren().
According to the definition of InnerNode, it must have children. And current
code InnerNode has getChildren().
{code:java}
/** @return its children */
List<Node> getChildren();
{code}
so i think it should add getNumOfChildren().
Please correct me if am wrong. Thank you [~ayushtkn].
> Add getNumOfChildren() for interface InnerNode
> ----------------------------------------------
>
> Key: HDFS-14936
> URL: https://issues.apache.org/jira/browse/HDFS-14936
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Lisheng Sun
> Priority: Minor
> Attachments: HDFS-14936.001.patch
>
>
> current code InnerNode subclass InnerNodeImpl and DFSTopologyNodeImpl both
> have getNumOfChildren().
> so Add getNumOfChildren() for interface InnerNode and remove unnessary
> getNumOfChildren() in DFSTopologyNodeImpl.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
