[ 
https://issues.apache.org/jira/browse/HDFS-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153819#comment-13153819
 ] 

Harsh J commented on HDFS-2572:
-------------------------------

Failing test is unrelated btw:

{code}
java.lang.Exception: test timed out after 20000 milliseconds
        at java.io.FileInputStream.readBytes(Native Method)
        at java.io.FileInputStream.read(FileInputStream.java:220)
        at 
sun.security.provider.SeedGenerator$URLSeedGenerator.getSeedBytes(SeedGenerator.java:493)
        at 
sun.security.provider.SeedGenerator.generateSeed(SeedGenerator.java:117)
        at 
sun.security.provider.SecureRandom.engineGenerateSeed(SecureRandom.java:114)
        at 
sun.security.provider.SecureRandom.engineNextBytes(SecureRandom.java:171)
        at java.security.SecureRandom.nextBytes(SecureRandom.java:433)
        at java.security.SecureRandom.next(SecureRandom.java:455)
        at java.util.Random.nextInt(Random.java:257)
        at 
org.apache.hadoop.hdfs.server.namenode.NNStorage.newBlockPoolID(NNStorage.java:990)
        at 
org.apache.hadoop.hdfs.server.namenode.NNStorage.format(NNStorage.java:537)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:136)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:607)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:149)
        at 
org.apache.hadoop.hdfs.DFSTestUtil.formatNameNode(DFSTestUtil.java:113)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:630)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:545)
        at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:261)
        at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:85)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:247)
        at 
org.apache.hadoop.hdfs.TestLocalDFS.testWorkingDirectory(TestLocalDFS.java:66)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
        at 
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
{code}

Seems like the machine ran out of entropy, and timed out.
                
> Unnecessary double-check in DN#getHostName
> ------------------------------------------
>
>                 Key: HDFS-2572
>                 URL: https://issues.apache.org/jira/browse/HDFS-2572
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2572.patch, HDFS-2572.patch
>
>
> We do a double config.get unnecessarily inside DN#getHostName(...). Can be 
> removed by this patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to