[
https://issues.apache.org/jira/browse/HDFS-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153967#comment-13153967
]
Konstantin Shvachko commented on HDFS-2514:
-------------------------------------------
I think the approach to return absolute paths is absolutely correct and the
patch looks good.
One tiny thing, I'd rather avoid using Path.SEPARATOR_CHAR in
UnresolvedPathException in favor of nested Path constructor:
- new Path(preceding + Path.SEPARATOR_CHAR + linkTarget, remainder);
+ new Path(new Path(preceding, linkTarget), remainder);
Other than that +1. Liked the JavaDoc improvements.
Briefly looked at the test cases in HADOOP-7783. Look reasonable.
We should fix this in 0.22 as well.
> Link resolution bug for intermediate symlinks with relative targets
> -------------------------------------------------------------------
>
> Key: HDFS-2514
> URL: https://issues.apache.org/jira/browse/HDFS-2514
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-2514-1.patch, hdfs-2514-2.patch
>
>
> There's a bug in the way the Namenode resolves intermediate symlinks (ie the
> symlink is not the final path component) in paths when the symlink's target
> is a relative path. Will post the full description in the first comment.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
