[
https://issues.apache.org/jira/browse/HDFS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154052#comment-13154052
]
Todd Lipcon commented on HDFS-2566:
-----------------------------------
After looking at the logs for a while, I figured out why
TestListCorruptFilesBlocks failed:
{code}
2011-11-20 02:18:43,178 INFO FSNamesystem.audit
(FSNamesystem.java:logAuditEvent(219)) - ugi=jenkins ip=/127.0.0.1
cmd=create src=/srcdat10/6588066362550844864 dst=null
perm=jenkins:supergroup:rw-r--r--
2011-11-20 02:18:43,180 INFO hdfs.StateChange
(FSNamesystem.java:completeFileInternal(1703)) - DIR* NameSystem.completeFile:
file /srcdat10/6588066362550844864 is closed by
DFSClient_NONMAPREDUCE_-1305344933_1
{code}
shows one of the test files being written with no blocks. The various
assertions in the test rely on the files all having at least one block, so the
test fails about one in 512 runs. I filed HDFS-2575 to deal with this.
Since all of the other tests passed without timeouts, etc, I think this patch
is fine. I'll commit tomorrow morning based on Eli's earlier +1 if there is no
objection.
> Move BPOfferService to be a non-inner class
> -------------------------------------------
>
> Key: HDFS-2566
> URL: https://issues.apache.org/jira/browse/HDFS-2566
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.1
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-2566.txt, hdfs-2566.txt, hdfs-2566.txt
>
>
> Rounding out the cleanup of BPOfferService, it would be good to move it to
> its own file, so it's no longer an inner class. DataNode.java is really large
> and hard to navigate. BPOfferService itself is ~700 lines, so seems like a
> large enough unit to merit its own file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
