[
https://issues.apache.org/jira/browse/HDDS-1515?focusedWorklogId=337815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337815
]
ASF GitHub Bot logged work on HDDS-1515:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/19 10:58
Start Date: 03/Nov/19 10:58
Worklog Time Spent: 10m
Work Description: akki commented on pull request #114: HDDS-1515. Add
hadolint checks
URL: https://github.com/apache/hadoop-ozone/pull/114
## What changes were proposed in this pull request?
Add Hadolint checks
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1515
## How was this patch tested?
Manually tested. Gives the following output currently
```
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:15
DL3006 Always tag the version of an image explicitly
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:16
DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add
<package>=<version>`
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:19
DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add
<package>=<version>`
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:19
DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and
remove `/var/cache/apk/*` when done installing packages
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:25
DL3003 Use WORKDIR to switch to a directory
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:37
DL4001 Either use Wget or Curl but not both
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:37
DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:42
DL4001 Either use Wget or Curl but not both
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:42
DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:47
DL3013 Pin versions in pip. Instead of `pip install <package>` use `pip
install <package>==<version>`
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:47
DL4001 Either use Wget or Curl but not both
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:50
DL4001 Either use Wget or Curl but not both
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:54
SC2086 Double quote to prevent globbing and word splitting.
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:54
DL4001 Either use Wget or Curl but not both
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:63
DL3003 Use WORKDIR to switch to a directory
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dev-support/docker/Dockerfile:63
DL4001 Either use Wget or Curl but not both
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:16
DL3006 Always tag the version of an image explicitly
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:17
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:19
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:20
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:21
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:22
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:23
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:26
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:27
DL3020 Use COPY instead of ADD for files and folders
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:28
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:29
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:30
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:31
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/compose/ozonescripts/Dockerfile:33
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/docker/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/src/main/docker/Dockerfile:17:26
unexpected '@' expecting the image tag
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/Dockerfile:19
DL3020 Use COPY instead of ADD for files and folders
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:16
DL3006 Always tag the version of an image explicitly
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:17
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:19
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:20
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:21
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:22
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:23
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:26
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:27
DL3020 Use COPY instead of ADD for files and folders
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:28
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:29
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:30
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:31
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/compose/ozonescripts/Dockerfile:33
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/Dockerfile:19
DL3020 Use COPY instead of ADD for files and folders
Checking
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:16
DL3006 Always tag the version of an image explicitly
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:17
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:19
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:20
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:21
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:22
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:23
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:26
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:27
DL3020 Use COPY instead of ADD for files and folders
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:28
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:29
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:30
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:31
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
/opt/hadoop-ozone/hadoop-ozone/dev-support/checks/../../../hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonescripts/Dockerfile:33
DL3004 Do not use sudo as it leads to unpredictable behavior. Use a tool like
gosu to enforce root
Hadolint errors were found. Exit code: 1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337815)
Remaining Estimate: 0h
Time Spent: 10m
> Create ozone dev-support script to check hadolint violiations
> -------------------------------------------------------------
>
> Key: HDDS-1515
> URL: https://issues.apache.org/jira/browse/HDDS-1515
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Marton Elek
> Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks/ directory contains helper scripts to execute
> different code quality checks locally.
> They are different from yetus as they can be executed in an easy way and they
> check _ALL_ the violation of the current code base.
> We need to create a new script to check the
> [hadolint|https://github.com/hadolint/hadolint] errors in the hadoop-ozone
> and hadoop-hdds projects.
> The contracts of the check scripts:
> # Exit code should define the result (0: passed, <>0 failed)
> # Violation should be printed out to the stdout
> We can assume that the hadolint is part of the development environment. For
> jenkins we can put it to the image of the dev builds.
> As the check introduce zero-tolerance for the hadolint violations the biggest
> issue here is to eliminate all of the existing issues.
> Thanks to [~eyang] for reporting that it's still missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
