[
https://issues.apache.org/jira/browse/HDDS-2408?focusedWorklogId=339448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339448
]
ASF GitHub Bot logged work on HDDS-2408:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 16:11
Start Date: 06/Nov/19 16:11
Worklog Time Spent: 10m
Work Description: fapifta commented on pull request #121: HDDS-2408 -
Separate OM Storage initialization from OzoneManager
URL: https://github.com/apache/hadoop-ozone/pull/121
## What changes were proposed in this pull request?
The changeset is the first step of a refactoring effort around OzoneManager
to clean up protobuf related code from OzoneManager and high level classes
encapsulate this to one class per protocol if possible. With that on the long
run, it helps to cleanup read path related code as well around
XCeiverClientManager but this particular change is really really far from that
point of the code.
The elements of the changeset:
- Extract Ozone Manager Storage initialization from OzoneManager class
- with that exctract all the SCM client protocol call related code from
OzoneManager, to have a common place to use from the Storage initialiser code,
and form OzoneManager itself.
- clear up unused code from OzoneManager after that
- fix test dependencies and set them to use the new code.
Steps that should come after this around the changed code:
- clear out the ScmClient class from OzoneManager and create and use it
where it is really used
- add the methods to the ScmClient class that are used from the two protocol
related class that is now returned by the ScmClient, and encapsulate protobuf
there.
I separated this to two different steps, as the main part here was to
separate OM Storage init, and common codes used by the storage init, and OM.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2408
## How was this patch tested?
Ran JUnit tests locally, as this is a refactoring, I just actualised the
test code to the proposed codebase, and ran the tests locally. Few timeout
related tests failed, but they do not seem to be even related to the changes,
we will see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339448)
Remaining Estimate: 0h
Time Spent: 10m
> Separate OM Storage initialization from OzoneManager
> ----------------------------------------------------
>
> Key: HDDS-2408
> URL: https://issues.apache.org/jira/browse/HDDS-2408
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Istvan Fajth
> Assignee: Istvan Fajth
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Ozone Manager Storage initialization is partly using the scm security
> client protocol.
> As a first step of cleaning up high level protobuf usage from the code, it is
> beneficial to separate this initialization code, so that it is clearly
> visible what parts of the SCM it is using, and later it helps to figure out
> the better design for the SCM security client related calls.
> This JIRA is aiming for the following separation tasks:
> - Clear out the OM Storage initialization related code from OzoneManager class
> - Clear out and move the common code that is used by OzoneManager class
> initialization and OzoneManager Storage initialization logic to avoid any
> duplication.
> - Clear unused stuff from OzoneManager after the changes.
> - To be the first step in a longer refactoring activity that clears out the
> SCM client and security client calls related code in OzoneManager and from
> things like KeyManager to have these abstracted from protobuf
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
