[
https://issues.apache.org/jira/browse/HDFS-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969498#comment-16969498
]
Íñigo Goiri commented on HDFS-14284:
------------------------------------
There must be something with the protobuf that needs to be added.
Anyway, the message works for sure and that one is passed.
In addition, it is easier to make the router id parameter mandatory and then
just send it over the message.
In my mind there are two benefits of using this {{RIOE(String msg)}}:
* It makes clear that it's a special issue coming from the Router.
* It makes it mandatory to specify the Router id so the exception will have
that in the exception.
Given this I would keep it this way.
I would also try to see if we can tweak the protobuf to be able to carry the
routerId separately.
If not possible, the current approach in [^HDFS-14284.008.patch] is fine with
me.
> RBF: Log Router identifier when reporting exceptions
> ----------------------------------------------------
>
> Key: HDFS-14284
> URL: https://issues.apache.org/jira/browse/HDFS-14284
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-14284.001.patch, HDFS-14284.002.patch,
> HDFS-14284.003.patch, HDFS-14284.004.patch, HDFS-14284.005.patch,
> HDFS-14284.006.patch, HDFS-14284.007.patch, HDFS-14284.008.patch
>
>
> The typical setup is to use multiple Routers through
> ConfiguredFailoverProxyProvider.
> In a regular HA Namenode setup, it is easy to know which NN was used.
> However, in RBF, any Router can be the one reporting the exception and it is
> hard to know which was the one.
> We should have a way to identify which Router/Namenode was the one triggering
> the exception.
> This would also apply with Observer Namenodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
