[ https://issues.apache.org/jira/browse/HDDS-2446?focusedWorklogId=340445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340445 ]
ASF GitHub Bot logged work on HDDS-2446: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/Nov/19 11:02 Start Date: 08/Nov/19 11:02 Worklog Time Spent: 10m Work Description: sodonnel commented on pull request #131: HDDS-2446 - ContainerReplica should contain DatanodeInfo rather than DatanodeDetails URL: https://github.com/apache/hadoop-ozone/pull/131 The ContainerReplica object is used by the SCM to track containers reported by the datanodes. The current fields stored in ContainerReplica are: ``` final private ContainerID containerID; final private ContainerReplicaProto.State state; final private DatanodeDetails datanodeDetails; final private UUID placeOfBirth; ``` Now we have introduced decommission and maintenance mode, the replication manager (and potentially other parts of the code) need to know the status of the replica in terms of IN_SERVICE, DECOMMISSIONING, DECOMMISSIONED etc to make replication decisions. The DatanodeDetails object does not carry this information, however the DatanodeInfo object extends DatanodeDetails and does carry the required information. As DatanodeInfo extends DatanodeDetails, any place which needs a DatanodeDetails can accept a DatanodeInfo instead. In this PR I propose we change the DatanodeDetails stored in ContainerReplica to DatanodeInfo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 340445) Remaining Estimate: 0h Time Spent: 10m > ContainerReplica should contain DatanodeInfo rather than DatanodeDetails > ------------------------------------------------------------------------ > > Key: HDDS-2446 > URL: https://issues.apache.org/jira/browse/HDDS-2446 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: SCM > Affects Versions: 0.5.0 > Reporter: Stephen O'Donnell > Assignee: Stephen O'Donnell > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The ContainerReplica object is used by the SCM to track containers reported > by the datanodes. The current fields stored in ContainerReplica are: > {code} > final private ContainerID containerID; > final private ContainerReplicaProto.State state; > final private DatanodeDetails datanodeDetails; > final private UUID placeOfBirth; > {code} > Now we have introduced decommission and maintenance mode, the replication > manager (and potentially other parts of the code) need to know the status of > the replica in terms of IN_SERVICE, DECOMMISSIONING, DECOMMISSIONED etc to > make replication decisions. > The DatanodeDetails object does not carry this information, however the > DatanodeInfo object extends DatanodeDetails and does carry the required > information. > As DatanodeInfo extends DatanodeDetails, any place which needs a > DatanodeDetails can accept a DatanodeInfo instead. > In this Jira I propose we change the DatanodeDetails stored in > ContainerReplica to DatanodeInfo. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org