[
https://issues.apache.org/jira/browse/HDDS-2448?focusedWorklogId=341288&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341288
]
ASF GitHub Bot logged work on HDDS-2448:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/19 13:05
Start Date: 11/Nov/19 13:05
Worklog Time Spent: 10m
Work Description: sodonnel commented on pull request #142: HDDS-2448
Delete container command should used a thread pool
URL: https://github.com/apache/hadoop-ozone/pull/142
…r than on the main commandDispatcher thread
## What changes were proposed in this pull request?
The datanode receives commands over the heartbeat and queues all commands on
a single queue in StateContext.commandQueue. Inside DatanodeStateMachine a
single thread is used to process this queue (started by initCommandHander
thread) and it passes each command to a ‘handler’. Each command type has its
own handler.
The delete container command immediately executes the command on the thread
used to process the command queue. Therefore if the delete is slow for some
reason (it must access disk, so this is possible) it could cause other commands
to backup.
This should be changed to use a threadpool to queue the deleteContainer
command, in a similar way to ReplicateContainerCommand.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341288)
Remaining Estimate: 0h
Time Spent: 10m
> Delete container command should used a thread pool
> --------------------------------------------------
>
> Key: HDDS-2448
> URL: https://issues.apache.org/jira/browse/HDDS-2448
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Affects Versions: 0.5.0
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The datanode receives commands over the heartbeat and queues all commands on
> a single queue in StateContext.commandQueue. Inside DatanodeStateMachine a
> single thread is used to process this queue (started by initCommandHander
> thread) and it passes each command to a ‘handler’. Each command type has its
> own handler.
> The delete container command immediately executes the command on the thread
> used to process the command queue. Therefore if the delete is slow for some
> reason (it must access disk, so this is possible) it could cause other
> commands to backup.
> This should be changed to use a threadpool to queue the deleteContainer
> command, in a similar way to ReplicateContainerCommand.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
