[
https://issues.apache.org/jira/browse/HDDS-2445?focusedWorklogId=342612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342612
]
ASF GitHub Bot logged work on HDDS-2445:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/19 14:01
Start Date: 13/Nov/19 14:01
Worklog Time Spent: 10m
Work Description: elek commented on pull request #132: HDDS-2445. Replace
ToStringBuilder in BlockData
URL: https://github.com/apache/hadoop-ozone/pull/132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342612)
Time Spent: 20m (was: 10m)
> Replace ToStringBuilder in BlockData
> ------------------------------------
>
> Key: HDDS-2445
> URL: https://issues.apache.org/jira/browse/HDDS-2445
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Labels: perfomance, pull-request-available
> Fix For: 0.5.0
>
> Attachments: blockdata.png, setchunks.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{BlockData#toString}} uses {{ToStringBuilder}} for ease of implementation.
> This has a few problems:
> # {{ToStringBuilder}} uses {{StringBuffer}}, which is synchronized
> # the default buffer is 512 bytes, more than needed here
> # {{BlockID}} and {{ContainerBlockID}} both use another {{StringBuilder}} or
> {{StringBuffer}} for their {{toString}} implementation, leading to several
> allocations and copies
> The flame graph shows that {{BlockData#toString}} may be responsible for 1.5%
> of total allocations while putting keys.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
