[
https://issues.apache.org/jira/browse/HDDS-2509?focusedWorklogId=344486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344486
]
ASF GitHub Bot logged work on HDDS-2509:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 18:57
Start Date: 15/Nov/19 18:57
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #185: HDDS-2509.
Code cleanup in replication package
URL: https://github.com/apache/hadoop-ozone/pull/185
## What changes were proposed in this pull request?
1. Fix simple Sonar warnings, eg.:
* do not declare throwing of unchecked exception
* use more specific exception instead of `RuntimeException`
* avoid nesting `try` blocks
* unused variables
* document empty method
2. Avoid `Thread.sleep` in the unit test. This required a more complex
refactoring. By using same-thread and "discarding" `ExecutorService` instead
of real multithreading. Also added success/failure counters in
`ReplicationSupervisor` for more specific state assertions. Can be exposed
later as metrics.
3. Remove duplicate (leftover?) `package-info.java` for
`org.apache.hadoop.ozone.container.replication` package.
https://issues.apache.org/jira/browse/HDDS-2509
## How was this patch tested?
Unit test (`TestReplicationSupervisor`). Also tested successful replication
in compose-based cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344486)
Remaining Estimate: 0h
Time Spent: 10m
> Code cleanup in replication package
> -----------------------------------
>
> Key: HDDS-2509
> URL: https://issues.apache.org/jira/browse/HDDS-2509
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
> Labels: pull-request-available, sonar
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fix couple of [issues
> reported|https://sonarcloud.io/project/issues?directories=hadoop-hdds%2Fcontainer-service%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fcontainer%2Freplication%2Chadoop-hdds%2Fcontainer-service%2Fsrc%2Ftest%2Fjava%2Forg%2Fapache%2Fhadoop%2Fozone%2Fcontainer%2Freplication&id=hadoop-ozone&resolved=false]
> in {{org.apache.hadoop.ozone.container.replication}} package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
