[
https://issues.apache.org/jira/browse/HDFS-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978766#comment-16978766
]
Ayush Saxena commented on HDFS-14999:
-------------------------------------
I don't have a fair idea, what exactly a exit condition should be. May be some
configurable number of retries? some hard coded value? or equal to number of
nodes?
This isn't a bug post HDFS-14913, but logically has a potential of getting
stuck long, if choose random keeps on returning the excluded node
Any suggestions?
> Avoid Potential Infinite Loop in DFSNetworkTopology
> ---------------------------------------------------
>
> Key: HDFS-14999
> URL: https://issues.apache.org/jira/browse/HDFS-14999
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
>
> {code:java}
> do {
> chosen = chooseRandomWithStorageTypeAndExcludeRoot(root, excludeRoot,
> type);
> if (excludedNodes == null || !excludedNodes.contains(chosen)) {
> break;
> } else {
> LOG.debug("Node {} is excluded, continuing.", chosen);
> }
> } while (true);
> {code}
> Observed this loop getting stuck as part of testing HDFS-14913.
> There should be some exit condition or max retries here
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
