[ https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980720#comment-16980720 ]
Jinglun commented on HDFS-14908: -------------------------------- Hi [~elgoiri], yes we should have a test on INodesInPath. I use a test case to compare INodesInPath and DFSUtil.isParent() and here is the result. Compare path=/dir0/dir1/dir2/dir3 and parent=/dir0/dir1 ||Time||10,000,000|| |DFSUtil.isParent()|400ms| |INodesInPath|33,940ms| The test case is in TestV4.patch. > LeaseManager should check parent-child relationship when filter open files. > --------------------------------------------------------------------------- > > Key: HDFS-14908 > URL: https://issues.apache.org/jira/browse/HDFS-14908 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.1.0, 3.0.1 > Reporter: Jinglun > Assignee: Jinglun > Priority: Minor > Attachments: HDFS-14908.001.patch, HDFS-14908.002.patch, > HDFS-14908.003.patch, HDFS-14908.004.patch, HDFS-14908.005.patch, Test.java, > TestV2.java, TestV3.java > > > Now when doing listOpenFiles(), LeaseManager only checks whether the filter > path is the prefix of the open files. We should check whether the filter path > is the parent/ancestor of the open files. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org