[ 
https://issues.apache.org/jira/browse/HDFS-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981409#comment-16981409
 ] 

Jinglun edited comment on HDFS-14908 at 11/25/19 9:27 AM:
----------------------------------------------------------

Hi [~elgoiri] [~weichiu], based on the result DFSUtil.isParent() is much 
faster. I think might be we can continue using the DFSUtil way, what do you 
think ?

v05 is not sync with trunk, so if we both agree with DFSUtil way I'll rebase 
v05 and prepare a new patch.


was (Author: lijinglun):
Hi [~elgoiri] [~weichiu], based on the result DFSUtil.isParent() is much 
faster. I think might be we can continue using the DFSUtil way ?

v05 is not sync with trunk, so if we both agree with DFSUtil way I'll rebase 
v05 and prepare a new patch.

> LeaseManager should check parent-child relationship when filter open files.
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-14908
>                 URL: https://issues.apache.org/jira/browse/HDFS-14908
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.1.0, 3.0.1
>            Reporter: Jinglun
>            Assignee: Jinglun
>            Priority: Minor
>         Attachments: HDFS-14908.001.patch, HDFS-14908.002.patch, 
> HDFS-14908.003.patch, HDFS-14908.004.patch, HDFS-14908.005.patch, 
> HDFS-14908.TestV4.patch, Test.java, TestV2.java, TestV3.java
>
>
> Now when doing listOpenFiles(), LeaseManager only checks whether the filter 
> path is the prefix of the open files. We should check whether the filter path 
> is the parent/ancestor of the open files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to