[
https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982255#comment-16982255
]
Yiqun Lin commented on HDFS-14649:
----------------------------------
Some review comments for the unit test:
* We can introduce one additional variable in Detector class, like
disabledProbeThreadForTest and then reset this value in the UT. We don't need
to add new config for this.
{code:java}
/**
* Disabled start probe suspect/dead thread for the testing.
*/
private volatile boolean disabledProbeThreadForTest = false;
...
@VisibleForTesting
public void disabledProbeThreadForTest() {
this.disabledProbeThreadForTest = true;
}
{code}
* Can we update the condition
dfsClient.getClientContext().getDeadNodeDetector().getSuspectNodesProbeQueue().size()
>= 1 to
dfsClient.getClientContext().getDeadNodeDetector().getSuspectNodesProbeQueue().size()
> 0?
> Add suspect probe for DeadNodeDetector
> --------------------------------------
>
> Key: HDFS-14649
> URL: https://issues.apache.org/jira/browse/HDFS-14649
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Attachments: HDFS-14649.001.patch, HDFS-14649.002.patch,
> HDFS-14649.003.patch, HDFS-14649.004.patch
>
>
> Add suspect probe for DeadNodeDetector.
> when some DataNode of the block is found to inaccessible, put the DataNode
> into it will be placed in the Suspicious Node list. Because when DataNode is
> not accessible, it is likely that the replica has been removed from the
> DataNode.Therefore, it needs to be confirmed by re-probing and requires a
> higher priority processing.
> And when DataNode is placed in the Suspicious Node list, it is accessed by
> other dfsinputstream.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
