[
https://issues.apache.org/jira/browse/HDFS-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983875#comment-16983875
]
Ayush Saxena commented on HDFS-14901:
-------------------------------------
Thanx [~hemanthboyina] for the patch.
* {{createEncryption}} is using invokeSequential, Though it was there already,
you just moved, but I feel it should check the order and then if it is PathAll
it should be invokeConcurrent, to support the multiple destinations as we are
doing in {{reencryptEncryptionZone}}
* For the test :
{code:java}
+ routerDFS.mkdirs(ezPath1);
+ routerDFS.mkdirs(ezPath);
+ routerProtocol.createEncryptionZone("/ez", TEST_KEY);
+ routerProtocol.createEncryptionZone("/ez1", TEST_KEY);
+ EncryptionZone ez = routerProtocol.getEZForPath("/ez/file");
{code}
For mkdir you are using routerDFS, but for Encryption API, you are using
routerProtocol, if no specific reason, you can use routerDFS only for both and
chunk of having {{routerProtocol}} from the test.
* The number of Datanodes for the test are 2 as of now(default, if you don't
specify explicitlly), if I see it correct, you are using replication factor of
1 for the file. I guess you can reduce the number to 1.
* Why you need this :
{code:java}
+ cluster.deleteAllFiles();
{code}
if that was @Before it would still make sense, but in @BeforeClass why?
> RBF: Add Encryption Zone related ClientProtocol APIs
> ----------------------------------------------------
>
> Key: HDFS-14901
> URL: https://issues.apache.org/jira/browse/HDFS-14901
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: hemanthboyina
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-14901.001.patch, HDFS-14901.002.patch
>
>
> Currently listEncryptionZones,reencryptEncryptionZone,listReencryptionStatus
> these APIs are not implemented in Router.
> This JIRA is intend to implement above mentioned APIs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
