[
https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984089#comment-16984089
]
Lisheng Sun commented on HDFS-15019:
------------------------------------
Thanks [~linyiqun] for your review.
the v001 pathc refactors the unit test of TestDeadNodeDetection.
> Refactor the unit test of TestDeadNodeDetection
> ------------------------------------------------
>
> Key: HDFS-15019
> URL: https://issues.apache.org/jira/browse/HDFS-15019
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Yiqun Lin
> Assignee: Lisheng Sun
> Priority: Minor
> Attachments: HDFS-15019.001.patch
>
>
> There are many duplicated lines in unit test \{{TestDeadNodeDetection}}. We
> can simplified that.
> In additional in {{testDeadNodeDetectionInMultipleDFSInputStream}}, the
> DFSInputstream is passed incorrectly in asset operation.
> {code}
> din2 = (DFSInputStream) in1.getWrappedStream();
> {code}
> Should be
> {code}
> din2 = (DFSInputStream) in2.getWrappedStream();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
