[
https://issues.apache.org/jira/browse/HDFS-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984105#comment-16984105
]
Íñigo Goiri commented on HDFS-14960:
------------------------------------
The whole point of NetworkTopologyWithNodeGroup is that it makes some nodes in
the same category.
So if the topology is not set to NetworkTopologyWithNodeGroup we should fail.
The proper way would be to have a test that would fail because is not getting
the expected functionality from DFSNetworkTopology.
In addition to that, we can add the pre-condition.
However, the priority is to have a test that would only pass with
NetworkTopologyWithNodeGroup.
> TestBalancerWithNodeGroup should not succeed with DFSNetworkTopology
> --------------------------------------------------------------------
>
> Key: HDFS-14960
> URL: https://issues.apache.org/jira/browse/HDFS-14960
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.3
> Reporter: Jim Brennan
> Priority: Minor
>
> As reported in HDFS-14958, TestBalancerWithNodeGroup was succeeding even
> though it was using DFSNetworkTopology instead of
> NetworkTopologyWithNodeGroup.
> [~inigoiri] rightly suggested that this indicates the test is not very good -
> it should fail when run without NetworkTopologyWithNodeGroup.
> We should improve this test.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
