[ 
https://issues.apache.org/jira/browse/HDFS-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984287#comment-16984287
 ] 

lindongdong commented on HDFS-12348:
------------------------------------

Hi, [~surendrasingh], thanks for your patch.

I find some problem with the patch: 

After we do rolling upgrade prepare, the old DN will move deleted file to 
trash. 

With this patch, the new DN will never delete the trash dir forever.

> disable removing blocks to trash while rolling upgrade
> ------------------------------------------------------
>
>                 Key: HDFS-12348
>                 URL: https://issues.apache.org/jira/browse/HDFS-12348
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode
>            Reporter: Jiandan Yang 
>            Assignee: Jiandan Yang 
>            Priority: Major
>         Attachments: HDFS-12348.001.patch, HDFS-12348.002.patch, 
> HDFS-12348.003.patch
>
>
> DataNode remove block file and meta file to trash while rolling upgrade,and 
> do delete when
> executing finalize. 
> This  leads disk of datanode to be full, because
> (1) frequently creating and deleting files(eg,Hbase compaction);
> (2) cluster is very big, and rolling upgrade often last several days;
> Current our solution is clean trash by hand, but this is very dangerous in 
> product environment. 
> we think disable trash of datanode maybe a good method to avoid disk to be 
> full.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to