[jira] [Commented] (HDFS-14983) RBF: Add dfsrouteradmin -refreshSuperUserGroupsConfiguration command option

[Xieming Li (Jira)]

    [ 
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993174#comment-16993174
 ] 

Xieming Li commented on HDFS-14983:
-----------------------------------

[~tasanuma], 

Thank you for your review.

I have posted a new patch that altered the 
RouterAdminServer#refreshSuperUserGroupsConfiguration() so that it pass the 
return code to the caller.
{code:java}
diff -u 
b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
 
b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
--- 
b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
+++ 
b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
@@ -357,7 +357,7 @@
       } else if ("-refreshRouterArgs".equals(cmd)) {
         exitCode = genericRefresh(argv, i);
       } else if ("-refreshSuperUserGroupsConfiguration".equals(cmd)) {
-        refreshSuperUserGroupsConfiguration();
+        exitCode = refreshSuperUserGroupsConfiguration();
       } else {
         throw new IllegalArgumentException("Unknown Command: " + cmd);
       }
@@ -402,7 +402,7 @@
    *
    * @throws IOException if the operation was not successful.
    */
-  private void refreshSuperUserGroupsConfiguration()
+  private int refreshSuperUserGroupsConfiguration()
       throws IOException{
     RouterGenericManager proxy = client.getRouterGenericManager();
     String address =  getConf().getTrimmed(
@@ -411,7 +411,9 @@
     if(proxy.refreshSuperUserGroupsConfiguration()){
       System.out.println(
           "Successfully updated superuser proxy groups on router " + address);
+      return 0;
     }
+    return  -1;
   }   private void refresh(String address) throws IOException {
{code}

> RBF: Add dfsrouteradmin -refreshSuperUserGroupsConfiguration command option
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-14983
>                 URL: https://issues.apache.org/jira/browse/HDFS-14983
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: Akira Ajisaka
>            Assignee: Xieming Li
>            Priority: Minor
>         Attachments: HDFS-14983.002.patch, HDFS-14983.003.patch, 
> HDFS-14983.004.patch, HDFS-14983.005.patch, HDFS-14983.draft.001.patch
>
>
> NameNode can update proxyuser config by -refreshSuperUserGroupsConfiguration 
> without restarting but DFSRouter cannot. It would be better for DFSRouter to 
> have such functionality to be compatible with NameNode.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org