[ 
https://issues.apache.org/jira/browse/HDFS-15094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009919#comment-17009919
 ] 

Íñigo Goiri commented on HDFS-15094:
------------------------------------

Let's add a comment explaining this operation is expensive and that we need to 
cache it.
Could you share a screenshot with the cost difference? 
BTW, I'm surprise that ugi doesn't have an efficient hash and equals method. 



> RBF : Reuse ugi string in ConnectionPoolID
> ------------------------------------------
>
>                 Key: HDFS-15094
>                 URL: https://issues.apache.org/jira/browse/HDFS-15094
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-15094-01.patch
>
>
> The connectionPoolID Hash Code and equals contains ugi.toString(), These 
> methods are used as part of getConnection() in ConnectionManager as part of 
> every call.
> The ugi.toString() eats up considerable amount of time, the Hash Calculation 
> itself is ~10 percent of the total time of the call. And even more for the 
> equals method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to