[
https://issues.apache.org/jira/browse/HDFS-15095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010110#comment-17010110
]
Jim Brennan edited comment on HDFS-15095 at 1/7/20 9:41 PM:
------------------------------------------------------------
Thanks for the patch [~ahussein]!
I am +1 (non-binding) on patch 002. Looks good to me!
was (Author: jim_brennan):
Thanks for the patch [~ahussein]! I am +1 (non-binding) on patch 002. Looks
good to me!
> Fix accidental comment in flaky test TestDecommissioningStatus
> --------------------------------------------------------------
>
> Key: HDFS-15095
> URL: https://issues.apache.org/jira/browse/HDFS-15095
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Attachments: HDFS-15095.001.patch, HDFS-15095.002.patch
>
>
> There are some old Jiras suggesting that "{{testDecommissionStatus"}} is
> flaky.
> * HDFS-12188
> * HDFS-9599
> * HDFS-9950
> * HDFS-10755
> However, HDFS-14854 fix accidentally commented out one of the checks in
> {{TestDecommissioningStatus.testDecommissionStatus()"}}. This Jira will
> restore the commented out code and adds a blocking queue to make the test
> case deterministic.
> My intuition is that monitor task launched by AdminManager may not have
> enough time to act before we start verifying the status. I suggest the force
> the main thread to block until the node is added to the blocked node.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
