[
https://issues.apache.org/jira/browse/HDFS-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011015#comment-17011015
]
Íñigo Goiri commented on HDFS-15096:
------------------------------------
Minor style comments:
* For RouterClientProtocol#127, let's add an extra break line to make it more
readable.
* For the break lines for reading getLong, I usually prefer putting it like
this:
{code}
this.serverDefaultsValidityPeriod = conf.getLong(
DFS_CLIENT_SERVER_DEFAULTS_VALIDITY_PERIOD_MS_KEY,
DFS_CLIENT_SERVER_DEFAULTS_VALIDITY_PERIOD_MS_DEFAULT);
{code}
> RBF: GetServerDefaults Should be Cached At Router
> -------------------------------------------------
>
> Key: HDFS-15096
> URL: https://issues.apache.org/jira/browse/HDFS-15096
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: GetServerDefault-Cached.PNG, HDFS-15096-01.patch,
> HDFS-15096-02.patch, Server-Before.PNG
>
>
> Presently each getServerDefault calls are triggered to the Namespace, The
> DFSClient caches the getServerDefaults(), similarly the Router can also cache
> the getServerDefaults(), as router connects to multiple clients, this
> improves performance for subsequent calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
