[
https://issues.apache.org/jira/browse/HDFS-15094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011017#comment-17011017
]
Íñigo Goiri commented on HDFS-15094:
------------------------------------
Yes, let's not touch ugi, it might be a little critical if it already does some
equals logic.
The savings in the profiling are not super spectacular but I think it makes
sense to go for it.
The existing tests should cover this optimization and nothing seems to break.
+1 on [^HDFS-15094-02.patch].
> RBF: Reuse ugi string in ConnectionPoolID
> -----------------------------------------
>
> Key: HDFS-15094
> URL: https://issues.apache.org/jira/browse/HDFS-15094
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15094-01.patch, HDFS-15094-02.patch,
> UGI_AFTER-01.PNG, UGI_BEFORE-01.PNG
>
>
> The connectionPoolID Hash Code and equals contains ugi.toString(), These
> methods are used as part of getConnection() in ConnectionManager as part of
> every call.
> The ugi.toString() eats up considerable amount of time, the Hash Calculation
> itself is ~10 percent of the total time of the call. And even more for the
> equals method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
