[
https://issues.apache.org/jira/browse/HDFS-15117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014861#comment-17014861
]
Vinayakumar B commented on HDFS-15117:
--------------------------------------
Patch almost looks good to me.
[~weichiu] , I too agree that DistributedFileSystem is a thin client.
Another fact is that, NameNode side already have this check and exposed as a
metric. See {{FSNamesystem#getVerifyECWithTopologyResult()}}.
So, it would be better to combine all these (DistributedFileSystem and
ECAdmin) to use the server side check.
In current implementation, {{getDatanodeReport()}} is used only to find
numberOfRacks. {{getDatanodeReport()}} is a bit costly RPC in large cluster.
So, to summarize, I feel can add a separate RPC to ClientProtocol and combine
existing serverside {{FSNamesystem#getVerifyECWithTopologyResult()}} to return
ECTopologyVerifierResult. Call this RPC in both DistributedFileSystem and
ECAdmin.
> EC: Add getECTopologyResultForPolicies to DistributedFileSystem
> ---------------------------------------------------------------
>
> Key: HDFS-15117
> URL: https://issues.apache.org/jira/browse/HDFS-15117
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15117-01.patch, HDFS-15117-02.patch
>
>
> Add getECTopologyResultForPolicies API to distributed filesystem.
> It is as of now only present as part of ECAdmin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
