[ 
https://issues.apache.org/jira/browse/HDFS-15112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014866#comment-17014866
 ] 

Ayush Saxena commented on HDFS-15112:
-------------------------------------

Thanx [~elgoiri]  for the patch. the UT in v004 seems to fail. There are two 
reasons :

first, The test expects unavailable 
{{RouterRpcClient.isUnavailableException(ioe)}} but the thrown is 
{{NoNamenodeException}}

Changing this :
{code:java}
+        if (isUnavailableException(ioe)) {
+          // We cannot conclude if this is a proper exception
+          RemoteLocationContext loc = locations.get(i);
+          String nsId = loc.getNameserviceId();
+          throw new NoNamenodesAvailableException(nsId, ioe);
+        }
{code}
to :
{code:java}
        if (isUnavailableException(ioe)) {
          // We cannot conclude if this is a proper exception
          throw ioe;
        }
{code}
 Works for me.

Secondly, Seems the jenkins didn't complained about this but the test failed at 
my local due to this, I think we should have 
{{refreshRoutersCaches({color:#660e7a}routers{color});}} after creating mount 
entry. SInce we are using random routers first for mount entry and then for 
filesystem.

 

Post these changes the UT seems to work fine, give a check once.

> RBF: Do not return FileNotFoundException when a subcluster is unavailable 
> --------------------------------------------------------------------------
>
>                 Key: HDFS-15112
>                 URL: https://issues.apache.org/jira/browse/HDFS-15112
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-15112.000.patch, HDFS-15112.001.patch, 
> HDFS-15112.002.patch, HDFS-15112.004.patch, HDFS-15112.patch
>
>
> If we have a mount point using HASH_ALL across two subclusters and one of 
> them is down, we may return FileNotFoundException while the file is just in 
> the unavailable subcluster.
> We should not return FileNotFoundException but something that shows that the 
> subcluster is unavailable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to