[
https://issues.apache.org/jira/browse/HDFS-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159539#comment-13159539
]
Sanjay Radia commented on HDFS-1971:
------------------------------------
I am reviewing the changes you made and have some additional minor changes;
will post an updated patch later today or early tomorrow.
Here is my feedback on your changes so far (more to come later today).
1) DatanodeRegistration getDNRegistrationByMachineName(String mName)
The TODO should be a separate jira - not related to this jira or HA.
2) public String getNamenodeAddresses() {
why removed the bpos.isALive() check that I had added: if (bpos != null &&
bpos.isAlive()) {
The trunk code has: if (bpos != null && bpos.bpThread != null) {
3) public void reportRemoteBadBlock(DatanodeInfo srcDataNode, ExtendedBlock
block) does not belong here and not much to do with HA. Separate Jira and
discussion.
> HA: Send block report from datanode to both active and standby namenodes
> ------------------------------------------------------------------------
>
> Key: HDFS-1971
> URL: https://issues.apache.org/jira/browse/HDFS-1971
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Suresh Srinivas
> Assignee: Sanjay Radia
> Attachments: DualBlockReports.pdf, daulBr1.patch, dualBr2.patch,
> dualBr3.patch, dualbr4.txt, dualbr5.txt
>
>
> To enable hot standby namenode, the standby node must have current
> information for - namenode state (image + edits) and block location
> information. This jira addresses keeping the block location information
> current in the standby node. To do this, the proposed solution is to send
> block reports from the datanodes to both the active and the standby namenode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
