[
https://issues.apache.org/jira/browse/HDFS-15125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018297#comment-17018297
]
Jim Brennan commented on HDFS-15125:
------------------------------------
Thanks for the review [~ahussein]! It's a good suggestion, but I don't think
it is necessary. When it times out, it is going to throw and unless the caller
catches it, the test will fail with an error. For example, I temporarily
reduced the timeout to force the timeout case, and got this in the output:
{noformat}
at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:373)
at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:373)
at
org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils.waitForDiskError(DataNodeTestUtils.java:248)
at
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure.testTolerateVolumeFailuresAfterAddingMoreVolumes(TestDataNodeVolumeFailure.java:395)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498) at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{noformat}
I'm also reluctant to make additional changes when pulling back fixes from
trunk.
> Pull back HDFS-11353, HDFS-13993, HDFS-13945, and HDFS-14324 to branch-2.10
> ---------------------------------------------------------------------------
>
> Key: HDFS-15125
> URL: https://issues.apache.org/jira/browse/HDFS-15125
> Project: Hadoop HDFS
> Issue Type: Test
> Components: hdfs
> Affects Versions: 2.10.0
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HDFS-15125-branch-2.10.001.patch,
> HDFS-15125-branch-2.10.002.patch
>
>
> I would like to pull back some fixes for the DataNodeVolume* tests to resolve
> some intermittent failures we are seeing on branch-2.10.
> The fixes are:
> HDFS-11353 Improve the unit tests relevant to DataNode volume failure testing
> HDFS-13993
> TestDataNodeVolumeFailure#testTolerateVolumeFailuresAfterAddingMoreVolumes is
> flaky
> HDFS-14324 Fix TestDataNodeVolumeFailure
> HDFS-13945 TestDataNodeVolumeFailure is Flaky
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
