[
https://issues.apache.org/jira/browse/HDFS-15167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038001#comment-17038001
]
Íñigo Goiri commented on HDFS-15167:
------------------------------------
* Let's extend the javadoc of scheduleBlockReport to document the parameters
and mention what does the isRegistration imply (probably the comment we have in
the assignment of resetBlockReportTime).
* In terms of doing a ternary in line 1264, let's do a full if where we add the
comment justifying why we do this.
> Block Report Interval shouldn't be reset apart from first Block Report
> ----------------------------------------------------------------------
>
> Key: HDFS-15167
> URL: https://issues.apache.org/jira/browse/HDFS-15167
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-15167-01.patch, HDFS-15167-02.patch,
> HDFS-15167-03.patch, HDFS-15167-04.patch, HDFS-15167-05.patch,
> HDFS-15167-06.patch
>
>
> Presently BlockReport interval is reset even in case the BR is manually
> triggered or BR is triggered for diskError.
> Which isn't required. As per the comment also, it is intended for first BR
> only :
> {code:java}
> // If we have sent the first set of block reports, then wait a random
> // time before we start the periodic block reports.
> if (resetBlockReportTime) {
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
