[
https://issues.apache.org/jira/browse/HDFS-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044629#comment-17044629
]
Ayush Saxena commented on HDFS-15120:
-------------------------------------
Thanx [~LiJinglun] for the update. The prod changes looks good
Regarding the test, seems both test have similar code, Can you refactor the
common part?
In the test use Junit asserts.
Like change :
{code:java}
assert(counter == lastCounter);
{code}
To assertEqual();
Seems TestDFSAdmin is related, give a check to others too once.
Apart LGTM
> Refresh BlockPlacementPolicy at runtime.
> ----------------------------------------
>
> Key: HDFS-15120
> URL: https://issues.apache.org/jira/browse/HDFS-15120
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15120.001.patch, HDFS-15120.002.patch,
> HDFS-15120.003.patch, HDFS-15120.004.patch, HDFS-15120.005.patch,
> HDFS-15120.006.patch, HDFS-15120.007.1.patch, HDFS-15120.007.patch
>
>
> Now if we want to switch BlockPlacementPolicies we need to restart the
> NameNode. It would be convenient if we can switch it at runtime. For example
> we can switch between AvailableSpaceBlockPlacementPolicy and
> BlockPlacementPolicyDefault as needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
