[ 
https://issues.apache.org/jira/browse/HDFS-15033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047188#comment-17047188
 ] 

Ayush Saxena commented on HDFS-15033:
-------------------------------------

Thanx [~hadoop_yangyun] for the patch . Had a quick look on this, Overall seems 
fine.
{code:java}
+
+<property>
+  <name>dfs.datanode.replica.cache.expiry.time.ms</name>
+  <value>300000</value>
+  <description>
+ Living time of replica cached files in milliseconds.
+ </description>

{code}
Here once we are using time units, we can set the value also with time suffix 
like 30000ms or may be you can set the value in seconds for better readability 
and I think in the configuration name and description we can remove ms, as it 
will supports all time units

Avoid tweaking the imports :
{code:java}
-import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ForkJoinPool;
-import java.util.concurrent.ForkJoinTask;
-import java.util.concurrent.RecursiveAction;
+import java.util.concurrent.*;
{code}

> Support to save replica cached files to other place and make expired time 
> configurable
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-15033
>                 URL: https://issues.apache.org/jira/browse/HDFS-15033
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-15033.patch
>
>
> For slow volume with many replicas,  add an option to save the replica files 
> to high-speed disk and speed up the saving.
>  Also add a option to change the expire time of the replica file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to