[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052447#comment-17052447
]
Íñigo Goiri commented on HDFS-15207:
------------------------------------
I think this is good, let's improve the readability a little:
* At the start of the else added in VolumeScanner, let's comment what we have
in the description of this JIRA: Check the access time of block file to avoid
scanning recently changed blocks, reducing disk IO.
* No need to check replica != null in line 549, if Im not wrong, instanceof
already handles that.
* When catching the IOException, let's log it as debug. It doesn't hurt and
potentially can help debuggability.
* In the test, when doing the waitFor, let's do it with a lambda.
* Let's avoid adding the 200ms sleep.
* Let's make readFiles private and add it next to the function where we use.
> VolumeScanner skip to scan blocks accessed during recent scan peroid
> --------------------------------------------------------------------
>
> Key: HDFS-15207
> URL: https://issues.apache.org/jira/browse/HDFS-15207
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15207.patch
>
>
> Check the access time of block file to avoid scanning recently changed
> blocks, reducing disk IO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
