[ 
https://issues.apache.org/jira/browse/HDFS-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059594#comment-17059594
 ] 

Ayush Saxena commented on HDFS-15154:
-------------------------------------

Thanx [~swagle] almost looks good.
Regarding depreciation of configuration. The configuration should work as it is 
post this change, means the tests using that configuration should not be 
affected. So, remove the changes from all the tests where the new configuration 
has been replaced with the new one. And the tests should ideally pass, if not 
we need to fix the deprecation logic.
The check should be inside the try block before the writelock, so that it can 
be added in audit log.

{code:java}
    try {
// Add checks here...
      writeLock();
      try {
{code}
 
Better we refactor and combine the checks into one method and call from both 
set and unset API's
Avoid Empty line change at L807 {{FSNamesystem}}


> Allow only hdfs superusers the ability to assign HDFS storage policies
> ----------------------------------------------------------------------
>
>                 Key: HDFS-15154
>                 URL: https://issues.apache.org/jira/browse/HDFS-15154
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.0.0
>            Reporter: Bob Cauthen
>            Assignee: Siddharth Wagle
>            Priority: Major
>         Attachments: HDFS-15154.01.patch, HDFS-15154.02.patch, 
> HDFS-15154.03.patch, HDFS-15154.04.patch, HDFS-15154.05.patch, 
> HDFS-15154.06.patch, HDFS-15154.07.patch, HDFS-15154.08.patch, 
> HDFS-15154.09.patch, HDFS-15154.10.patch, HDFS-15154.11.patch, 
> HDFS-15154.12.patch
>
>
> Please provide a way to limit only HDFS superusers the ability to assign HDFS 
> Storage Policies to HDFS directories.
> Currently, and based on Jira HDFS-7093, all storage policies can be disabled 
> cluster wide by setting the following:
> dfs.storage.policy.enabled to false
> But we need a way to allow only HDFS superusers the ability to assign an HDFS 
> Storage Policy to an HDFS directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to