[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061370#comment-17061370
]
Fengnan Li edited comment on HDFS-15196 at 3/18/20, 4:03 AM:
-------------------------------------------------------------
Thanks for the review [~elgoiri] I added another logic handling in
[^HDFS-15196.007.patch] for the listing of only mount points. This missing
logic caused the test failure in the [^HDFS-15196.006.patch] .
I have tested this on an actual host with ~2k children and it worked compared
to without the fix it only listed out 1.1 k.
was (Author: fengnanli):
Thanks for the review [~elgoiri] I added another logic handling in
[^HDFS-15196.007.patch] for the listing of only mount points. This missing
logic caused the test failure in the [^HDFS-15196.006.patch] .
I have tested this on an actual host with ~2k children and it worked file
compared to without the fix it only listed out 1.1 k.
> RBF: RouterRpcServer getListing cannot list large dirs correctly
> ----------------------------------------------------------------
>
> Key: HDFS-15196
> URL: https://issues.apache.org/jira/browse/HDFS-15196
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Critical
> Attachments: HDFS-15196.001.patch, HDFS-15196.002.patch,
> HDFS-15196.003.patch, HDFS-15196.003.patch, HDFS-15196.004.patch,
> HDFS-15196.005.patch, HDFS-15196.006.patch, HDFS-15196.007.patch
>
>
> In RouterRpcServer, getListing function is handled as two parts:
> # Union all partial listings from destination ns + paths
> # Append mount points for the dir to be listed
> In the case of large dir which is bigger than DFSConfigKeys.DFS_LIST_LIMIT
> (with default value 1k), the batch listing will be used and the startAfter
> will be used to define the boundary of each batch listing. However, step 2
> here will add existing mount points, which will mess up with the boundary of
> the batch, thus making the next batch startAfter wrong.
> The fix is just to append the mount points when there is no more batch query
> necessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
