[
https://issues.apache.org/jira/browse/HDFS-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063805#comment-17063805
]
Xiaoqiao He edited comment on HDFS-15180 at 3/21/20, 7:57 AM:
--------------------------------------------------------------
Not sure why Jenkins report not attach here. Just forward the result generated
by Jenkins here and it seems there are unit tests failed, maybe it is related
with this changes. [~Aiphag0] please take another check. Also some checkstyle
warning need to fix.
-1 overall
|Vote|Subsystem|Runtime|Comment|
|0|reexec|25m 55s|Docker mode activated.|
| | | |Prechecks|
|+1|@author|0m 0s|The patch does not contain any @author|
| | | |tags.|
|+1|test4tests|0m 0s|The patch appears to include 9 new or|
| | | |modified test files.|
| | | |trunk Compile Tests|
|+1|mvninstall|19m 47s|trunk passed|
|+1|compile|1m 0s|trunk passed|
|+1|checkstyle|0m 48s|trunk passed|
|+1|mvnsite|1m 6s|trunk passed|
|+1|shadedclient|16m 8s|branch has no errors when building and|
| | | |testing our client artifacts.|
|+1|findbugs|2m 47s|trunk passed|
|+1|javadoc|0m 39s|trunk passed|
| | | |Patch Compile Tests|
|+1|mvninstall|1m 2s|the patch passed|
|+1|compile|0m 56s|the patch passed|
|-1|javac|0m 56s|hadoop-hdfs-project_hadoop-hdfs|
| | | |generated 1 new + 585 unchanged - 0|
| | | |fixed = 586 total (was 585)|
|-0|checkstyle|0m 43s|hadoop-hdfs-project/hadoop-hdfs: The|
| | | |patch generated 33 new + 460 unchanged|
| | | | - 1 fixed = 493 total (was 461)|
|+1|mvnsite|1m 3s|the patch passed|
|+1|whitespace|0m 0s|The patch has no whitespace issues.|
|+1|shadedclient|14m 6s|patch has no errors when building and|
| | | |testing our client artifacts.|
|-1|findbugs|2m 57s|hadoop-hdfs-project/hadoop-hdfs|
| | | |generated 1 new + 0 unchanged - 0 fixed|
| | | |= 1 total (was 0)|
|+1|javadoc|0m 37s|the patch passed|
| | | |Other Tests|
|-1|unit|110m 35s|hadoop-hdfs in the patch passed.|
|+1|asflicense|0m 38s|The patch does not generate ASF|
| | | |License warnings.|
| | |200m 51s| |
||Reason||Tests||
|FindBugs|module:hadoop-hdfs-project/hadoop-hdfs
Should org.apache.hadoop.hdfs.server.datanode.BlockPoolLockManager$TrackLog be
a _static_ inner class? At BlockPoolLockManager.java:inner class? At
BlockPoolLockManager.java:[lines 62-92]|
|Failed junit tests|hadoop.hdfs.server.datanode.TestBlockPoolLockManager|
| |hadoop.hdfs.server.namenode.ha.TestHAFsck|
| |hadoop.hdfs.server.datanode.TestBPOfferService|
| |hadoop.hdfs.TestDecommissionWithStriped|
| |hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery|
| |hadoop.hdfs.server.datanode.TestBlockRecovery|
||Subsystem||Report/Notes||
|Docker|Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:367833cf417|
|JIRA Issue|HDFS-15180|
|JIRA Patch URL|[^HDFS-15180.002.patch]|
|Optional Tests|dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle|
|uname|Linux 590078cb7ea7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28
UTC 2019 x86_64 x86_64 x86_64 GNU/Linux|
|Build tool|maven|
|Personality|/testptch/patchprocess/precommit/personality/provided.sh|
|git revision|trunk / 36123170381|
|maven|version: Apache Maven 3.6.0|
|Default Java|1.8.0_242|
|findbugs|v3.1.0-RC1|
|javac|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt]|
|checkstyle|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt]|
|findbugs|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html]|
|unit|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt]|
|Test
Results|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/testReport/]|
|Max. process+thread count|2998 (vs. ulimit of 5500)|
|modules|C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs|
|Console
output|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/console]|
|Powered by|Apache Yetus 0.8.0
[http://yetus.apache.org|http://yetus.apache.org/]|
was (Author: hexiaoqiao):
Not sure why Jenkins report not attach here. Just forward the result generated
by Jenkins here and it seems there are unit tests failed, maybe it is related
with this changes. [~Aiphag0] please take another check. Also some checkstyle
warning need to fix.
-1 overall
|Vote|Subsystem|Runtime|Comment|
|0|reexec|25m 55s|Docker mode activated.|
| | | |Prechecks|
|+1|@author|0m 0s|The patch does not contain any @author|
| | | |tags.|
|+1|test4tests|0m 0s|The patch appears to include 9 new or|
| | | |modified test files.|
| | | |trunk Compile Tests|
|+1|mvninstall|19m 47s|trunk passed|
|+1|compile|1m 0s|trunk passed|
|+1|checkstyle|0m 48s|trunk passed|
|+1|mvnsite|1m 6s|trunk passed|
|+1|shadedclient|16m 8s|branch has no errors when building and|
| | | |testing our client artifacts.|
|+1|findbugs|2m 47s|trunk passed|
|+1|javadoc|0m 39s|trunk passed|
| | | |Patch Compile Tests|
|+1|mvninstall|1m 2s|the patch passed|
|+1|compile|0m 56s|the patch passed|
|-1|javac|0m 56s|hadoop-hdfs-project_hadoop-hdfs|
| | | |generated 1 new + 585 unchanged - 0|
| | | |fixed = 586 total (was 585)|
|-0|checkstyle|0m 43s|hadoop-hdfs-project/hadoop-hdfs: The|
| | | |patch generated 33 new + 460 unchanged|
| | | | - 1 fixed = 493 total (was 461)|
|+1|mvnsite|1m 3s|the patch passed|
|+1|whitespace|0m 0s|The patch has no whitespace issues.|
|+1|shadedclient|14m 6s|patch has no errors when building and|
| | | |testing our client artifacts.|
|-1|findbugs|2m 57s|hadoop-hdfs-project/hadoop-hdfs|
| | | |generated 1 new + 0 unchanged - 0 fixed|
| | | |= 1 total (was 0)|
|+1|javadoc|0m 37s|the patch passed|
| | | |Other Tests|
|-1|unit|110m 35s|hadoop-hdfs in the patch passed.|
|+1|asflicense|0m 38s|The patch does not generate ASF|
| | | |License warnings.|
| | |200m 51s|
||Reason||Tests||
|FindBugs|module:hadoop-hdfs-project/hadoop-hdfs
Should org.apache.hadoop.hdfs.server.datanode.BlockPoolLockManager$TrackLog be
a _static_ inner class? At BlockPoolLockManager.java:inner class? At
BlockPoolLockManager.java:[lines 62-92]|
|Failed junit tests|hadoop.hdfs.server.datanode.TestBlockPoolLockManager|
| |hadoop.hdfs.server.namenode.ha.TestHAFsck|
| |hadoop.hdfs.server.datanode.TestBPOfferService|
| |hadoop.hdfs.TestDecommissionWithStriped|
| |hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery|
| |hadoop.hdfs.server.datanode.TestBlockRecovery|
||Subsystem||Report/Notes||
|Docker|Client=19.03.8 Server=19.03.8 Image:yetus/hadoop:367833cf417|
|JIRA Issue|HDFS-15180|
|JIRA Patch URL|[^HDFS-15180.002.patch]|
|Optional Tests|dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle|
|uname|Linux 590078cb7ea7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28
UTC 2019 x86_64 x86_64 x86_64 GNU/Linux|
|Build tool|maven|
|Personality|/testptch/patchprocess/precommit/personality/provided.sh|
|git revision|trunk / 36123170381|
|maven|version: Apache Maven 3.6.0|
|Default Java|1.8.0_242|
|findbugs|v3.1.0-RC1|
|javac|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt]|
|checkstyle|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt]|
|findbugs|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html]|
|unit|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt]|
|Test
Results|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/testReport/]|
|Max. process+thread count|2998 (vs. ulimit of 5500)|
|modules|C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs|
|Console
output|[https://builds.apache.org/job/PreCommit-HDFS-Build/28991/console]|
|Powered by|Apache Yetus 0.8.0
[http://yetus.apache.org|http://yetus.apache.org/]|
> DataNode FsDatasetImpl Fine-Grained Locking via BlockPool.
> -----------------------------------------------------------
>
> Key: HDFS-15180
> URL: https://issues.apache.org/jira/browse/HDFS-15180
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: zhuqi
> Assignee: Aiphago
> Priority: Major
> Attachments: HDFS-15180.001.patch, HDFS-15180.002.patch,
> HDFS-15180.003.patch, image-2020-03-10-17-22-57-391.png,
> image-2020-03-10-17-31-58-830.png, image-2020-03-10-17-34-26-368.png
>
>
> Now the FsDatasetImpl datasetLock is heavy, when their are many namespaces in
> big cluster. If we can split the FsDatasetImpl datasetLock via blockpool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
