[
https://issues.apache.org/jira/browse/HDFS-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162544#comment-13162544
]
Eli Collins commented on HDFS-2627:
-----------------------------------
Overall looks good.
Per the TODO in updateActorStatesFromHeartbeat not sure what you mean by "stop
talking" but I think just returning as you have the code is appropriate, no
sense in blacklisting a standby because we got an out-of-date heartbeat.
In BPOfferService#isAlive why not return the OR of all threads? If HA is
configured we should require an active thread for both the active and standby
right?
> HA: determine DN's view of which NN is active based on heartbeat responses
> --------------------------------------------------------------------------
>
> Key: HDFS-2627
> URL: https://issues.apache.org/jira/browse/HDFS-2627
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2627-v1.txt
>
>
> This is the first part of the design described in [this
> comment|https://issues.apache.org/jira/browse/HDFS-1972?focusedCommentId=13160601&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13160601]
> in HDFS-1972. When the DNs start, they should not consider either of the NNs
> in a block pool to be the active one. Rather, the NNs should include their HA
> state as part of the heartbeat response to the DN, and the DN will believe
> whichever NN claims to be active at a higher transaction ID.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira