[
https://issues.apache.org/jira/browse/HDFS-15238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066202#comment-17066202
]
Íñigo Goiri commented on HDFS-15238:
------------------------------------
It makes sense to cache it; I'm guessing you have profiled this and the size is
significant?
We make want to reset it with the exceptions just in case.
So my comments would be:
* When we catch the exception, set localTargetHAProtocol to null.
* Add a javadoc comment to localTargetHAProtocol:
{code}
/** Cachec HA protocol. */
private HAServiceProtocol localTargetHAProtocol;
{code}
> RBF：NamenodeHeartbeatService caused memory to grow rapidly
> ----------------------------------------------------------
>
> Key: HDFS-15238
> URL: https://issues.apache.org/jira/browse/HDFS-15238
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: xuzq
> Assignee: xuzq
> Priority: Major
> Attachments: HDFS-15238-trunk-001.patch
>
>
> NamenodeHeartbeatService will get NameNode's HA status every 5s, and created
> HAServiceProtocol every time.
> When creating HAServiceProtocol, it also will new Configuration.
> Over time, there will be more and more entries for REGISTER in Configuration
> until fullGc happen.
> The entry will piles up again, after reaching a certain threshold, the
> fullGc is triggered again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
