[ https://issues.apache.org/jira/browse/HDFS-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162574#comment-13162574 ]
Sanjay Radia commented on HDFS-2581: ------------------------------------ # Rename JournalProtocolTranslatorR23 to JournalProtocolTranslatorPB (in package hdfs.protocolProtocolBuffers) Suggestion: change null to NULL_CONTROLLER in the rpc calls. # JournalPBProtocolImpl - Please call it JournalProtocolServerSideTranslatorPB to be consistent with the naming convention in writables and to reflect that this is the SS of of JournalProtocolTranslatorPB. The real impl is inside the NN. Change javadoc comment to: This is the server side translator that forwards the request to the real impl of the protocol after translating the parameters from PB types to the native type of the implementation. # JournaPBProtocol - rename to JournalProtocolPB Add the annnotation ProtocolInfo(protocolName=org.apache.hadoop.hdfs.server.protocol.JournalProtocol (define a constant). You can also add a version number to the annotation instead of the static VersionID. > Implement protobuf service for JournalProtocol > ---------------------------------------------- > > Key: HDFS-2581 > URL: https://issues.apache.org/jira/browse/HDFS-2581 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: 0.24.0 > > Attachments: HDFS-2581.txt, HDFS-2581.txt, HDFS-2581.txt > > > This jira adds implementation for JournalProtocol protobuf service along the > same lines as HDFS-2181 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira