[ 
https://issues.apache.org/jira/browse/HDFS-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162621#comment-13162621
 ] 

Suresh Srinivas commented on HDFS-2618:
---------------------------------------

Todd,

Changing BlockWithLocations which used String for indicating DatanodeID to 
DatanodeIDProto:
{noformat}
message DatanodeIDProto {
  required string name = 1;      // hostname:portNumber
  required string storageID = 2; // Unique storage id
  required uint32 infoPort = 3;  // the port where the infoserver is running
  required uint32 ipcPort = 4;   // the port where the ipc Server is running
}
{noformat}

seems unnecessary and excessive. BlockWithLocations can change to incorporate 
more information in the future instead of doing this. I did not pay close 
attention to this when I code reviewed the previous change.

Hence changing it back to be equivalent to the existing protocol.
                
> Implement protobuf service for NamenodeProtocol
> -----------------------------------------------
>
>                 Key: HDFS-2618
>                 URL: https://issues.apache.org/jira/browse/HDFS-2618
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: name-node
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2618.txt, HDFS-2618.txt
>
>
> This jira adds implementation for NamenodeProtocol protobuf service along the 
> same lines as HDFS-2181

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to