[
https://issues.apache.org/jira/browse/HDFS-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069928#comment-17069928
]
Íñigo Goiri edited comment on HDFS-14385 at 3/28/20, 3:28 PM:
--------------------------------------------------------------
In addition to the checkstyles, this breaks something in a lot of tests.
Can you take a look?
For startCluster(), it may make sense to not have such a long method and have:
{code}
public void startCluster(Configuration overrideConf) {
if (isMockNamenode) {
startClusterMock(overrideConf);
} else {
startClusterFull(overrideConf);
}
}
{code}
was (Author: elgoiri):
In addition to the checkstyles, this breaks something in a lot of tests.
Can you take a look?
> RBF: Optimize MiniRouterDFSCluster with optional light weight MiniDFSCluster
> ----------------------------------------------------------------------------
>
> Key: HDFS-14385
> URL: https://issues.apache.org/jira/browse/HDFS-14385
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Xiaoqiao He
> Assignee: Xiaoqiao He
> Priority: Major
> Attachments: HDFS-14385-HDFS-13891.001.patch, HDFS-14385.002.patch
>
>
> MiniRouterDFSCluster mimic federated HDFS cluster with routers to support RBF
> test, In MiniRouterDFSCluster, it starts MiniDFSCluster with complete roles
> of HDFS which have significant time cost. As HDFS-14351 discussed, it is
> better to provide mock MiniDFSCluster/Namenodes as one option to support some
> test case and reduce time cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
