[ 
https://issues.apache.org/jira/browse/HDFS-15248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070380#comment-17070380
 ] 

Íñigo Goiri edited comment on HDFS-15248 at 3/29/20, 3:14 PM:
--------------------------------------------------------------

Thanks [~weichiu] for chiming it.
That was the reason why I was checking for the use case.
I'll let you decide if this should be done or not.

Regarding the patch itself, the unit test should do something like:
{code}
LambdaTestUtils.intercept(
  AclException.class,
  () -> filterDefaultAclEntries(existing));

LambdaTestUtils.intercept(
  AclException.class,
  "which exceeds maximum of",
  () -> filterDefaultAclEntries(existing));
{code}


was (Author: elgoiri):
Thanks [~weichiu] for chiming it.
That was the reason why I was checking for the use case.
I'll let you decide if this should be done or not.

Regarding the patch itself, the unit test should do something like:
{code}
LambdaTestUtils.intercept(
  AclException.class,
  () -> filterDefaultAclEntries(existing));

LambdaTestUtils.intercept(
  AclException.class,
  "which exceeds maximum of",
  () -> filterDefaultAclEntries(existing));
{code{

> Make the maximum number of ACLs entries configurable
> ----------------------------------------------------
>
>                 Key: HDFS-15248
>                 URL: https://issues.apache.org/jira/browse/HDFS-15248
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-15248.001.patch, HDFS-15248.patch
>
>
> For big cluster, the hardcode 32 of ACLs maximum number is not enough, make 
> it configurable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to