[ 
https://issues.apache.org/jira/browse/HDFS-15233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073707#comment-17073707
 ] 

Takanobu Asanuma commented on HDFS-15233:
-----------------------------------------

Thanks for working on this, [~hemanthboyina].

I tested the patch, and it almost works well. Some comments:
 * Could you add some unit tests to TestContentSummary or(and) TestCount.
 * The output format seems off. I think we want the numbers to fit the right 
edge of the headers, like quota.

Snapshot Output:

!HDFS-15233.002.output.png|width=693,height=35!

Quota Output:

!quota.output.png|width=631,height=39!

> Add -S option in "Count" command to show only Snapshot Counts
> -------------------------------------------------------------
>
>                 Key: HDFS-15233
>                 URL: https://issues.apache.org/jira/browse/HDFS-15233
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: hemanthboyina
>            Assignee: hemanthboyina
>            Priority: Major
>         Attachments: HDFS-15233.001.patch, HDFS-15233.002.output.png, 
> HDFS-15233.002.patch, quota.output.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to