[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074851#comment-17074851
]
Wei-Chiu Chuang edited comment on HDFS-15207 at 4/3/20, 7:38 PM:
-----------------------------------------------------------------
Patch makes sense tom me. Thanks for working on this [~hadoop_yangyun]
In the test code:
{code}
assertTrue("Should not run to here", false);
{code}
+1 after the test code change.
Can you use {{LambdaTestUtils#intercept()}} instead, or use the more
traditional {{fail()}}
{{VolumeScanner#runLoop()}} is quite long now. Time to refactor it. Can be a
separate jira to refactor that method.
was (Author: jojochuang):
Patch makes sense tom me. Thanks for working on this [~hadoop_yangyun]
In the test code:
{code}
assertTrue("Should not run to here", false);
{code}
Can you use {{LambdaTestUtils#intercept()}} instead, or use the more
traditional {{fail()}}
{{VolumeScanner#runLoop()}} is quite long now. Time to refactor it. Can be a
separate jira to refactor that method.
> VolumeScanner skip to scan blocks accessed during recent scan peroid
> --------------------------------------------------------------------
>
> Key: HDFS-15207
> URL: https://issues.apache.org/jira/browse/HDFS-15207
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15207.002.patch, HDFS-15207.003.patch,
> HDFS-15207.patch, HDFS-15207.patch
>
>
> Check the access time of block file to avoid scanning recently changed
> blocks, reducing disk IO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
